drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...
Date Fri, 14 Jul 2017 00:07:10 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/860#discussion_r127360560
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/SpillSet.java
---
    @@ -413,7 +419,12 @@ public SpillSet(DrillConfig config, FragmentHandle handle, PhysicalOperator
popC
           fileManager = new HadoopFileManager(spillFs);
         }
     
    -    spillDirName = String.format("%s_%s_%s-%s_minor%s", QueryIdHelper.getQueryId(handle.getQueryId()),
    +    // If provided with a prefix to identify the Drillbit, prepend that to the
    +    // spill directory.
    +
    +    spillDirName = String.format("%s%s_%s_%s-%s-%s",
    +        ep == null ? "" : ep.getAddress() + "-" + ep.getUserPort() + "/",
    --- End diff --
    
    Any chance the address would be "" ?  Then the directory name would start with a "-" which
could cause some trouble (probably only for access from the shell, thus OK).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message