drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...
Date Thu, 13 Jul 2017 22:21:22 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/860#discussion_r127345445
  
    --- Diff: exec/vector/src/main/java/org/apache/drill/exec/vector/complex/BaseRepeatedValueVector.java
---
    @@ -210,13 +212,15 @@ protected void replaceDataVector(ValueVector v) {
       }
     
       @Override
    -  public int getAllocatedByteCount() {
    -    return offsets.getAllocatedByteCount() + vector.getAllocatedByteCount();
    +  public void getLedgers(Set<BufferLedger> ledgers) {
    --- End diff --
    
    This method looks more like a "set" than a "get" .....



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message