drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #870: DRILL-5664: Enable security for Drill HiveStoragePl...
Date Wed, 12 Jul 2017 01:30:32 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/870#discussion_r126839078
  
    --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveStoragePluginConfig.java
---
    @@ -33,6 +33,8 @@
     
       public static final String NAME = "hive";
     
    +  public static final String HIVE_SECURITY_CONFIG = "hive.metastore.sasl.enabled";
    --- End diff --
    
    Fine to define this config option here. But, since this is Hive, and Hive has its own
`drill-module.conf` file, please provide a default option value in that file. (The config
system will throw an exception if the requested option is undefined.)
    
    Then, if you expect users to change this, please provide an example and description in
`drill-override-example.conf`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message