drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #868: DRILL-5547:Linking config options with system optio...
Date Tue, 11 Jul 2017 23:54:48 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/868#discussion_r126828858
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
---
    @@ -193,6 +231,7 @@
     
       private final PersistentStoreProvider provider;
     
    +  private DrillConfig bootConfig = null;
    --- End diff --
    
    ```
    private final DrillConfig bootConfig;
    ```
    
    This way, the member can be set exactly once in the constructor, which you are doing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message