drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #865: DRILL-5634 - Add Crypto and Hash Functions
Date Mon, 03 Jul 2017 09:51:26 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/865#discussion_r125245365
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoHelperFunctions.java
---
    @@ -0,0 +1,85 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * <p/>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p/>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.drill.exec.expr.fn.impl;
    +import javax.crypto.Cipher;
    +import javax.crypto.spec.SecretKeySpec;
    +import javax.xml.bind.DatatypeConverter;
    +import java.io.UnsupportedEncodingException;
    +import java.security.MessageDigest;
    +import java.security.NoSuchAlgorithmException;
    +import java.util.Arrays;
    +
    +public class CryptoHelperFunctions {
    +
    +    private static SecretKeySpec secretKey;
    +    private static byte[] key;
    +
    +    public static void setKey(String myKey)
    +    {
    +        MessageDigest sha = null;
    +        try {
    +            key = myKey.getBytes("UTF-8");
    +            sha = MessageDigest.getInstance("SHA-1");
    +            key = sha.digest(key);
    +            key = Arrays.copyOf(key, 16);
    +            secretKey = new SecretKeySpec(key, "AES");
    +        }
    +        catch (NoSuchAlgorithmException e) {
    --- End diff --
    
    1. Please use multi-catch.
    2. Please remove e.printStackTrace() and log error instead here and in the code below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message