Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C62F4200CB5 for ; Wed, 28 Jun 2017 02:16:18 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C367D160BF6; Wed, 28 Jun 2017 00:16:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0965D160BDC for ; Wed, 28 Jun 2017 02:16:17 +0200 (CEST) Received: (qmail 74259 invoked by uid 500); 28 Jun 2017 00:16:17 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 74237 invoked by uid 99); 28 Jun 2017 00:16:16 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jun 2017 00:16:16 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id BA758DFB92; Wed, 28 Jun 2017 00:16:16 +0000 (UTC) From: paul-rogers To: dev@drill.apache.org Reply-To: dev@drill.apache.org References: In-Reply-To: Subject: [GitHub] drill pull request #831: DRILL-5432: Added pcap-format support Content-Type: text/plain Message-Id: <20170628001616.BA758DFB92@git1-us-west.apache.org> Date: Wed, 28 Jun 2017 00:16:16 +0000 (UTC) archived-at: Wed, 28 Jun 2017 00:16:19 -0000 Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/831#discussion_r124427218 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapDrillTable.java --- @@ -0,0 +1,73 @@ +/* --- End diff -- The JIRA link is also good. Once the code is into Drill, it will be hard for future users to locate the corresponding JIRA. But, if you place a comment into a file somewhere, then future developers can find the JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---