Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-851-drill@git.apache.org>
In-Reply-To: <git-pr-851-drill@git.apache.org>
Subject: [GitHub] drill pull request #851: DRILL-5518: Test framework enhancements
Content-Type: text/plain
Message-Id: <20170621234214.37DADE0898@git1-us-west.apache.org>
Date: Wed, 21 Jun 2017 23:42:14 +0000 (UTC)
archived-at: Wed, 21 Jun 2017 23:42:17 -0000

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/851#discussion_r123138411
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/SubOperatorTest.java ---
    @@ -0,0 +1,37 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + ******************************************************************************/
    +package org.apache.drill.test;
    +
    +import org.junit.AfterClass;
    +import org.junit.BeforeClass;
    +
    +public class SubOperatorTest extends DrillTest {
    +
    +  protected static OperatorFixture fixture;
    +
    +  @BeforeClass
    +  public static void setUpBeforeClass() throws Exception {
    +    fixture = OperatorFixture.standardFixture();
    +  }
    +
    +  @AfterClass
    +  public static void tearDownAfterClass() throws Exception {
    --- End diff --
    
    There is a reason... Junit also allows a \@Before and \@After tag that are per-test actions. Those are often called `setup()` and `teardown()`. The static per-class versions are often called with the names used here. Still, renamed them to be a bit clearer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---