Return-Path: <dev-return-29766-archive-asf-public=cust-asf.ponee.io@drill.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id B7EDA200CAE
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 21 Jun 2017 21:36:49 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id B5FD4160BD5; Wed, 21 Jun 2017 19:36:49 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 2D37E160BD0
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 21 Jun 2017 21:36:49 +0200 (CEST)
Received: (qmail 67748 invoked by uid 500); 21 Jun 2017 19:36:43 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 67703 invoked by uid 99); 21 Jun 2017 19:36:41 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Jun 2017 19:36:41 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id AF59ADFA6C; Wed, 21 Jun 2017 19:36:39 +0000 (UTC)
From: vdiravka <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-824-drill@git.apache.org>
In-Reply-To: <git-pr-824-drill@git.apache.org>
Subject: [GitHub] drill pull request #824: DRILL-3867: Store relative paths in metadata file
Content-Type: text/plain
Message-Id: <20170621193639.AF59ADFA6C@git1-us-west.apache.org>
Date: Wed, 21 Jun 2017 19:36:39 +0000 (UTC)
archived-at: Wed, 21 Jun 2017 19:36:49 -0000

Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/824#discussion_r123331277
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java ---
    @@ -748,6 +771,22 @@ public ParquetTableMetadataDirs(List<String> directories) {
           return directories;
         }
     
    +    /** If directories list contains relative paths, update it to absolute ones
    --- End diff --
    
    Yes, we do, internally we use absolute paths (for the FileSelection, FileStatus, ReadEntryWithPath). 
    
    By the way it is possible to convert paths to absolute ones just before retrieving, but converting immediately after deserializing has advantages: avoiding of the keeping the metadata with appropriate `baseDir`, avoiding of the over number of checking the type of the path and avoiding an extra converting paths (when the data is retrieved several times from one metadata object).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---