Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: kkhatua <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-858-drill@git.apache.org>
In-Reply-To: <git-pr-858-drill@git.apache.org>
Subject: [GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...
Content-Type: text/plain
Message-Id: <20170621183246.0C795DFBDA@git1-us-west.apache.org>
Date: Wed, 21 Jun 2017 18:32:46 +0000 (UTC)
archived-at: Wed, 21 Jun 2017 18:32:52 -0000

Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/858#discussion_r123330684
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
    @@ -422,6 +507,9 @@ public ResultSet getGeneratedKeys() throws SQLException {
       public int executeUpdate(String sql, int autoGeneratedKeys) throws SQLException {
         throwIfClosed();
         try {
    +      if (timeoutTrigger != null) {
    --- End diff --
    
    I'm submit the timeout trigger to the pool and counting on that trigger doing a query cancellation to do that. I don't think Drill supports executeUpdate, but as long as a query cancellation for updates does the rollback of the transaction, this should suffice. This worked well for large queries where the execute###() call was longer than the timeout period and allowed for the cancellation to do the interrupt.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---