Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-840-drill@git.apache.org>
In-Reply-To: <git-pr-840-drill@git.apache.org>
Subject: [GitHub] drill pull request #840: DRILL-5517: Size-aware set methods in value vectors
Content-Type: text/plain
Message-Id: <20170621020853.0340EDFE5C@git1-us-west.apache.org>
Date: Wed, 21 Jun 2017 02:08:53 +0000 (UTC)
archived-at: Wed, 21 Jun 2017 02:08:55 -0000

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/840#discussion_r123129149
  
    --- Diff: exec/memory/base/src/main/java/io/netty/buffer/UnsafeDirectLittleEndian.java ---
    @@ -174,6 +175,40 @@ public ByteBuf setDouble(int index, double value) {
         return this;
       }
     
    +  // Clone of the super class checkIndex, but this version returns a boolean rather
    +  // than throwing an exception.
    +
    +  protected boolean hasCapacity(int index, int fieldLength) {
    +    if (fieldLength < 0) {
    --- End diff --
    
    Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---