drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #862: DRILL-5420: ParquetAsyncPgReader goes into infinite...
Date Wed, 28 Jun 2017 17:49:22 GMT
GitHub user kkhatua opened a pull request:

    https://github.com/apache/drill/pull/862

    DRILL-5420: ParquetAsyncPgReader goes into infinite loop during cleanup

    PageQueue is cleaned up using poll() instead of take(), which constantly gets interrupted
and causes CPU churn.
    During a columnReader shutdown, a flag is set so as to block any new page reading tasks
from being submitted, before the queues are finally cleared and memory occupied by the pages
released.
    More details are in this JIRA comment : https://issues.apache.org/jira/browse/DRILL-5420?focusedCommentId=16066933&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16066933

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kkhatua/drill DRILL-5420

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/862.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #862
    
----
commit 2f233d4b1318e29211856877937ef9988c34ffaf
Author: Kunal Khatua <kkhatua@maprtech.com>
Date:   2017-06-28T06:35:34Z

    DRILL-5420: ParquetAsyncPgReader goes into infinite loop during cleanup
    
    PageQueue is cleaned up using poll() instead of take(), which constantly gets interrupted
and causes CPU churn.
    During a columnReader shutdown, a flag is set so as to block any new page reading tasks
from being submitted.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message