drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #853: DRILL-5130: Fix explainTerms method for Values node...
Date Thu, 15 Jun 2017 17:11:44 GMT
GitHub user arina-ielchiieva opened a pull request:

    https://github.com/apache/drill/pull/853

    DRILL-5130: Fix explainTerms method for Values nodes to describe two different Values
nodes correctly

    1. Factor out common logic for DrillValuesRel and ValuesPrel into DrillValuesRelBase.
    2. Revisit explainTerms to write full tuples content so consequently Values nodes with
the same row type and count but different values are considered to be different.
    3. Minor refactoring.
    
    Details in Jira DRILL-5130.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arina-ielchiieva/drill DRILL-5130

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/853.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #853
    
----
commit 598a44f81cec5fdfc005573c39d790ff1b20eb6b
Author: Arina Ielchiieva <arina.yelchiyeva@gmail.com>
Date:   2017-06-15T15:03:34Z

    DRILL-5130: Fix explainTerms method for Values nodes to describe two different Values
nodes correctly
    
    1. Factor out common logic for DrillValuesRel and ValuesPrel into DrillValuesRelBase.
    2. Revisit explainTerms to write full tuples content so consequently Values nodes with
the same row type and count but different values are considered to be different.
    3. Minor refactoring.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message