drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill issue #831: DRILL-5432: Added pcap-format support
Date Fri, 30 Jun 2017 16:55:40 GMT
Github user paul-rogers commented on the issue:

    https://github.com/apache/drill/pull/831
  
    Looking at the big picture, Drill should allow specialized plugins such as this one to
exist as independent projects. Users should be able to download the plugin jar, add it to
Drill, and go.
    
    As we've discussed, Drill has a bit of work before we get there. We can't hold up this
work waiting for a better solution.
    
    So, please fix the two minor issues you identified. The code will then be ready for a
final quick review and approval.
    
    Later, once Drill provides the correct framework, I'd suggest that this code move into
a separate Github repo to be maintained by experts in pcap. Frankly, most Drill developers
are familiar with query engines, not pcap (or other specialized formats.)
    
    The same is true, for example, of the "indexr" and TSDB plugins which are (slowly) working
their way through the review process.
    
    Summary: please add the package-info file and the comments in utils. We can then give
approval.
    
    Can we do this by, say, July 10? If so, we can likely get this PR into 1.11, if the Release
Manager agrees.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message