drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #851: DRILL-5518: Test framework enhancements
Date Thu, 22 Jun 2017 00:30:17 GMT
Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/851#discussion_r123397308
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/test/RowSetTest.java
---
    @@ -309,13 +317,38 @@ private void testDoubleRW() {
         assertEquals(0, reader.column(0).getDouble(), 0.000001);
         assertTrue(reader.next());
         assertEquals(Double.MAX_VALUE, reader.column(0).getDouble(), 0.000001);
    +    assertEquals(Double.MAX_VALUE, (double) reader.column(0).getObject(), 0.000001);
    --- End diff --
    
    Yes but my understanding is that `RowSetReader.column(0)` will return `ColumnReader` and
you implemented `getObject` in `AbstractColumnReader` which is handing the type there. So
`getObject` will return correct type of value ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message