drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdiravka <...@git.apache.org>
Subject [GitHub] drill pull request #824: DRILL-3867: Store relative paths in metadata file
Date Wed, 21 Jun 2017 19:36:44 GMT
Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/824#discussion_r123339909
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
    @@ -748,6 +771,22 @@ public ParquetTableMetadataDirs(List<String> directories) {
           return directories;
         }
     
    +    /** If directories list contains relative paths, update it to absolute ones
    +     * @param baseDir base parent directory
    +     */
    +    @JsonIgnore public void updateRelativePaths(Path baseDir) {
    +      if (!directories.isEmpty()) {
    +        // It is enough to check the first path to decide if updating needed
    +        if (!new Path(directories.get(0)).isAbsolute()) {
    --- End diff --
    
    It is possible to replace String with Path for directories paths due to implementing custom
`JsonSerializer<Path>` and `JsonDeserializer<Path>`. But then it will be necessary
to convert every `Path` from lists back into `String`, because a String paths are used in
a lot of places: `FileSelection`, `Metadata`, `ParquetGroupScan`, `ReadEntryWithPath`, `FileWork`,
`FormatSelection`, `FormatPlugin`,  `PartitionLocation`and so on.
    
    I am totally agree with replacing `String` with `Path` requirement. But it should be done
not only for parquet and in context of separate jira. I am going to create it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message