drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdiravka <...@git.apache.org>
Subject [GitHub] drill pull request #824: DRILL-3867: Store relative paths in metadata file
Date Wed, 21 Jun 2017 19:36:39 GMT
Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/824#discussion_r123331277
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
    @@ -748,6 +771,22 @@ public ParquetTableMetadataDirs(List<String> directories) {
           return directories;
         }
     
    +    /** If directories list contains relative paths, update it to absolute ones
    --- End diff --
    
    Yes, we do, internally we use absolute paths (for the FileSelection, FileStatus, ReadEntryWithPath).

    
    By the way it is possible to convert paths to absolute ones just before retrieving, but
converting immediately after deserializing has advantages: avoiding of the keeping the metadata
with appropriate `baseDir`, avoiding of the over number of checking the type of the path and
avoiding an extra converting paths (when the data is retrieved several times from one metadata
object).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message