drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...
Date Wed, 21 Jun 2017 18:26:25 GMT
Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/858#discussion_r123329050
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
    @@ -204,7 +276,7 @@ public boolean isClosed() {
     
       @Override
       public int getMaxFieldSize() throws SQLException {
    -    throwIfClosed();
    +    throwIfTimedOutOrClosed();
    --- End diff --
    
    The throwIfTimedOutOrClosed() call is basically a wrapper around a sequential check for,
first the timed-out state, followed by the check for the closed state. A timed-out query (i.e.
statement/resultset) is already in a closed state, but we need to throw the correct exception
(in this case, the timeout), which is why it was done like that. 
    My understanding was that any execute and data fetch operations can throw timeoutExceptions.
Are you suggesting that for such '_getter_' methods, only an AlreadyClosed exception needs
to be thrown and not time out?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message