drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...
Date Wed, 21 Jun 2017 18:10:44 GMT
Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/858#discussion_r123325052
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/SqlTimeoutException.java ---
    @@ -23,12 +23,17 @@
      * Indicates that an operation timed out. This is not an error; you can
      * retry the operation.
      */
    -public class SqlTimeoutException
    -    extends SQLException
    -{
    +public class SqlTimeoutException extends SQLException {
    +
    +  private static final long serialVersionUID = 2017_06_20L;
    --- End diff --
    
    Fair enough... will set it to a -1. 
    I saw a similar assignment for _InvalidParameterSqlException_ , which was set as a timestamp,
so I just tried to follow the convention.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message