drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #851: DRILL-5518: Test framework enhancements
Date Tue, 20 Jun 2017 00:44:33 GMT
Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/851#discussion_r122854874
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/SchemaBuilder.java
---
    @@ -53,6 +53,47 @@
     public class SchemaBuilder {
     
       /**
    +   * Build a column schema (AKA "materialized field") based on name and a
    +   * variety of schema options. Every column needs a name and (minor) type,
    +   * some may need a mode other than required, may need a width, may
    +   * need scale and precision, and so on.
    +   */
    +
    +  // TODO: Add map methods
    +
    +  public static class ColumnBuilder {
    +    private String name;
    +    private MajorType.Builder typeBuilder;
    --- End diff --
    
    private `final`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message