drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #849: DRILL-5568: Include hadoop-common jars inside drill...
Date Mon, 19 Jun 2017 19:21:15 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/849#discussion_r122796433
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/SecurityConfiguration.java
---
    @@ -0,0 +1,44 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.rpc.security;
    +
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.fs.CommonConfigurationKeys;
    +
    +
    +public class SecurityConfiguration extends Configuration {
    +  //private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(SecurityConfiguration.class);
    +
    +  public SecurityConfiguration() {
    +    super();
    +    updateGroupMapping();
    +  }
    +
    +  /**
    +   * Update the Group Mapping class name to add namespace prefix retrieved from System
Property. This is needed since
    +   * in drill-jdbc-all jar we are packaging hadoop dependencies under that namespace.
This will help application
    +   * using this jar as driver to avoid conflict with it's own hadoop dependency if any.
    +   */
    +  private void updateGroupMapping() {
    +    final String originalClassName = get(CommonConfigurationKeys.HADOOP_SECURITY_GROUP_MAPPING);
    +    final String profilePrefix = System.getProperty("namespacePrefix");
    --- End diff --
    
    Would recommend a name that is a bit less generic. Maybe "drill.security.namespacePrefix"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message