drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #849: DRILL-5568: Include hadoop-common jars inside drill...
Date Mon, 19 Jun 2017 19:21:13 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/849#discussion_r122800022
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillFactory.java ---
    @@ -37,6 +38,24 @@
       protected final int major;
       protected final int minor;
     
    +  static {
    +    Properties prop = new Properties();
    --- End diff --
    
    Actually, I think this code can be moved into `SecurityConfiguration.java`.
    
    Java handles resources by looking in the class path, which is formed from all jars. A
long as the resource file is somewhere in the top level of some jar, this code will find it.
So, despite what I said in person the other day, the code need not be here to work.
    
    That said, the property file DOES have to be in the JDBC-all package to avoid having multiple
files of the same name in the class path.
    
    Please try it out to see if the code works in `SecurityConfiguration.java`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message