drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bitblender <...@git.apache.org>
Subject [GitHub] drill pull request #840: DRILL-5517: Size-aware set methods in value vectors
Date Mon, 19 Jun 2017 15:18:52 GMT
Github user bitblender commented on a diff in the pull request:

    https://github.com/apache/drill/pull/840#discussion_r118806486
  
    --- Diff: exec/memory/base/src/main/java/io/netty/buffer/UnsafeDirectLittleEndian.java
---
    @@ -174,6 +175,40 @@ public ByteBuf setDouble(int index, double value) {
         return this;
       }
     
    +  // Clone of the super class checkIndex, but this version returns a boolean rather
    +  // than throwing an exception.
    +
    +  protected boolean hasCapacity(int index, int fieldLength) {
    +    if (fieldLength < 0) {
    --- End diff --
    
    change this to an assertion as per our discussion?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message