drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #824: DRILL-3867: Store relative paths in metadata file
Date Sun, 18 Jun 2017 22:54:33 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/824#discussion_r122602623
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
    @@ -748,6 +771,22 @@ public ParquetTableMetadataDirs(List<String> directories) {
           return directories;
         }
     
    +    /** If directories list contains relative paths, update it to absolute ones
    +     * @param baseDir base parent directory
    +     */
    +    @JsonIgnore public void updateRelativePaths(Path baseDir) {
    +      if (!directories.isEmpty()) {
    +        // It is enough to check the first path to decide if updating needed
    +        if (!new Path(directories.get(0)).isAbsolute()) {
    --- End diff --
    
    This is getting a bit silly, converting to/from String and Path. The `directories` list
should contain Path elements. In general, we should never work with Path as strings except
if we need to serialize as in Jackson.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message