drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdiravka <...@git.apache.org>
Subject [GitHub] drill pull request #824: DRILL-3867: Store relative paths in metadata file
Date Fri, 16 Jun 2017 22:54:52 GMT
Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/824#discussion_r122515967
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
    @@ -680,7 +731,7 @@ private boolean tableModified(List<String> directories, Path
metaFilePath,
       }
     
       public static abstract class ParquetFileMetadata {
    -    @JsonIgnore public abstract String getPath();
    +    @JsonIgnore public abstract ParquetPath getParquetPath();
    --- End diff --
    
    The structure of metadata cache file isn't changed and deserializing works properly for
new relative paths and for old absolute ones (`new Path(parent, child)` in `deserialize()`
method). 
    
    In the new approach after deserializing list of paths are checked and updated from relative
paths to absolute ones.
    Leaving relative paths in metadata may cause to repeated converting of the paths and checking
in a lot of places the kind of path.
    If old meta cache file is deserialized with absolute paths, nothing is made with them
and an old mechanism works.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message