drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #822: DRILL-5457: Spill implementation for Hash Aggregate
Date Thu, 15 Jun 2017 21:21:32 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r122310219
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
    @@ -130,6 +127,7 @@
       private int currentIndex = 0;
       private IterOutcome outcome;
       private int numGroupedRecords = 0;
    +  private int currentBatchRecordCount = 0; // Performance: Avoid repeated calls to getRecordCount()
    --- End diff --
    
    Not sure that the very small savings in time is worth the complexity of keeping a cached
copy in sync. If needed for an inner loop, can it be a local variable instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message