drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bitblender <...@git.apache.org>
Subject [GitHub] drill pull request #837: DRILL-5514: Enhance VectorContainer to merge two ro...
Date Thu, 15 Jun 2017 19:15:40 GMT
Github user bitblender commented on a diff in the pull request:

    https://github.com/apache/drill/pull/837#discussion_r122287096
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/record/TestVectorContainer.java
---
    @@ -110,13 +110,16 @@ public void testContainerMerge() {
         RowSet mergedRs = left.merge(right);
         comparison.verifyAndClear(mergedRs);
     
    -    // Add a selection vector. Ensure the SV appears in the merged
    -    // result. Test as a row set since container's don't actually
    -    // carry the selection vector.
    +    // Add a selection vector. Merging is forbidden.
    --- End diff --
    
    Maybe this can be changed to "//Merging data with a selection vector is forbidden". As
is the comment implies that we are adding a selection vector.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message