drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #808: DRILL-5325: Unit tests for the managed sort
Date Tue, 06 Jun 2017 22:40:46 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/808#discussion_r120485024
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
---
    @@ -346,9 +346,7 @@ public IterOutcome innerNext() {
                   if (unionTypeEnabled) {
                     this.schema = SchemaUtil.mergeSchemas(schema, incoming.getSchema());
                   } else {
    -                throw SchemaChangeException.schemaChanged("Schema changes not supported
in External Sort. Please enable Union type",
    -                    schema,
    -                    incoming.getSchema());
    +                throw new SchemaChangeException("Schema changes not supported in External
Sort. Please enable Union type");
    --- End diff --
    
    Fixed. Converted to a UserException, else the fragment executor will wrap the schema change
exception with some generic message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message