Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-822-drill@git.apache.org>
In-Reply-To: <git-pr-822-drill@git.apache.org>
Subject: [GitHub] drill pull request #822: DRILL-5457: Spill implementation for Hash Aggregate
Content-Type: text/plain
Message-Id: <20170527053806.2D357E9638@git1-us-west.apache.org>
Date: Sat, 27 May 2017 05:38:06 +0000 (UTC)
archived-at: Sat, 27 May 2017 05:38:09 -0000

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r118812151
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java ---
    @@ -230,15 +452,35 @@ public void setup(HashAggregate hashAggrConfig, HashTableConfig htConfig, Fragme
           throw new IllegalArgumentException("Wrong number of workspace variables.");
         }
     
    -//    this.context = context;
    +    this.context = context;
         this.stats = stats;
    -    this.allocator = allocator;
    +    this.allocator = oContext.getAllocator();
    +    this.oContext = oContext;
         this.incoming = incoming;
    -//    this.schema = incoming.getSchema();
         this.outgoing = outgoing;
         this.outContainer = outContainer;
    +    this.operatorId = hashAggrConfig.getOperatorId();
    +
    +    is2ndPhase = hashAggrConfig.getAggPhase() == AggPrelBase.OperatorPhase.PHASE_2of2;
    +    isTwoPhase = hashAggrConfig.getAggPhase() != AggPrelBase.OperatorPhase.PHASE_1of1;
    +    canSpill = isTwoPhase; // single phase can not spill
    --- End diff --
    
    All this state is copied for each generated class. But, nothing here is specific to the types of the vectors in the batches. As noted above, all this stuff should be factored out into a non-template class with the template holding only that code which is type-specific.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---