Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-831-drill@git.apache.org>
In-Reply-To: <git-pr-831-drill@git.apache.org>
Subject: [GitHub] drill pull request #831: DRILL-5432: Added pcap-format support
Content-Type: text/plain
Message-Id: <20170526014417.F2BADF2184@git1-us-west.apache.org>
Date: Fri, 26 May 2017 01:44:17 +0000 (UTC)
archived-at: Fri, 26 May 2017 01:44:23 -0000

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/831#discussion_r118615528
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapFormatPlugin.java ---
    @@ -0,0 +1,115 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to you under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + * <p>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.pcap;
    +
    +import com.google.common.collect.ImmutableList;
    +import com.google.common.collect.Lists;
    +import org.apache.drill.common.exceptions.ExecutionSetupException;
    +import org.apache.drill.common.expression.SchemaPath;
    +import org.apache.drill.common.logical.StoragePluginConfig;
    +import org.apache.drill.exec.ops.FragmentContext;
    +import org.apache.drill.exec.planner.logical.DrillTable;
    +import org.apache.drill.exec.server.DrillbitContext;
    +import org.apache.drill.exec.store.RecordReader;
    +import org.apache.drill.exec.store.RecordWriter;
    +import org.apache.drill.exec.store.dfs.BasicFormatMatcher;
    +import org.apache.drill.exec.store.dfs.DrillFileSystem;
    +import org.apache.drill.exec.store.dfs.FileSelection;
    +import org.apache.drill.exec.store.dfs.FileSystemPlugin;
    +import org.apache.drill.exec.store.dfs.FormatMatcher;
    +import org.apache.drill.exec.store.dfs.FormatSelection;
    +import org.apache.drill.exec.store.dfs.MagicString;
    +import org.apache.drill.exec.store.dfs.NamedFormatPluginConfig;
    +import org.apache.drill.exec.store.dfs.easy.EasyFormatPlugin;
    +import org.apache.drill.exec.store.dfs.easy.EasyWriter;
    +import org.apache.drill.exec.store.dfs.easy.FileWork;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.fs.Path;
    +
    +import java.io.IOException;
    +import java.util.List;
    +import java.util.regex.Pattern;
    +
    +public class PcapFormatPlugin extends EasyFormatPlugin<PcapFormatConfig> {
    +
    +  private final PcapFormatMatcher matcher;
    +
    +  public PcapFormatPlugin(String name, DrillbitContext context, Configuration fsConf,
    +                          StoragePluginConfig storagePluginConfig) {
    +    this(name, context, fsConf, storagePluginConfig, new PcapFormatConfig());
    +  }
    +
    +  public PcapFormatPlugin(String name, DrillbitContext context, Configuration fsConf, StoragePluginConfig config, PcapFormatConfig formatPluginConfig) {
    +    super(name, context, fsConf, config, formatPluginConfig, true, false, true, false, Lists.newArrayList("pcap"), "pcap");
    +    this.matcher = new PcapFormatMatcher(this);
    +  }
    +
    +  @Override
    +  public boolean supportsPushDown() {
    +    return true;
    +  }
    +
    +  @Override
    +  public RecordReader getRecordReader(FragmentContext context, DrillFileSystem dfs, FileWork fileWork, List<SchemaPath> columns, String userName) throws ExecutionSetupException {
    +    String path = dfs.makeQualified(new Path(fileWork.getPath())).toUri().getPath();
    +    return new PcapRecordReader(path, columns);
    +  }
    +
    +  @Override
    +  public RecordWriter getRecordWriter(FragmentContext context, EasyWriter writer) throws IOException {
    +    return null;
    +  }
    +
    +  @Override
    +  public int getReaderOperatorType() {
    +    return 0;
    +  }
    +
    +  @Override
    +  public int getWriterOperatorType() {
    +    return 0;
    --- End diff --
    
    Other format plugins do the following when a writer is not supported:
    
    ```
        throw new UnsupportedOperationException("unimplemented");
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---