Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: vvysotskyi <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-805-drill@git.apache.org>
In-Reply-To: <git-pr-805-drill@git.apache.org>
Subject: [GitHub] drill pull request #805: Drill-4139: Exception while trying to prune partiti...
Content-Type: text/plain
Message-Id: <20170524095025.10B0DDFF9F@git1-us-west.apache.org>
Date: Wed, 24 May 2017 09:50:25 +0000 (UTC)
archived-at: Wed, 24 May 2017 09:50:27 -0000

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/805#discussion_r117736018
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java ---
    @@ -508,21 +516,32 @@ public void populatePruningVector(ValueVector v, int index, SchemaPath column, S
             NullableVarBinaryVector varBinaryVector = (NullableVarBinaryVector) v;
             Object s = partitionValueMap.get(f).get(column);
             byte[] bytes;
    -        if (s instanceof Binary) {
    -          bytes = ((Binary) s).getBytes();
    -        } else if (s instanceof String) {
    -          bytes = ((String) s).getBytes();
    -        } else if (s instanceof byte[]) {
    -          bytes = (byte[]) s;
    +        if (s == null) {
    +          varBinaryVector.getMutator().setNull(index);
    +          return;
             } else {
    -          throw new UnsupportedOperationException("Unable to create column data for type: " + type);
    +          bytes = getBytes(type, s);
             }
             varBinaryVector.getMutator().setSafe(index, bytes, 0, bytes.length);
             return;
           }
           case DECIMAL18: {
             NullableDecimal18Vector decimalVector = (NullableDecimal18Vector) v;
    -        Long value = (Long) partitionValueMap.get(f).get(column);
    +        Object s = partitionValueMap.get(f).get(column);
    --- End diff --
    
    Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---