Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: Ben-Zvi <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-822-drill@git.apache.org>
In-Reply-To: <git-pr-822-drill@git.apache.org>
Subject: [GitHub] drill pull request #822: DRILL-5457: Spill implementation for Hash Aggregate
Content-Type: text/plain
Message-Id: <20170522234038.9C23CDFB8A@git1-us-west.apache.org>
Date: Mon, 22 May 2017 23:40:38 +0000 (UTC)
archived-at: Mon, 22 May 2017 23:40:41 -0000

Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r117869278
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -64,6 +64,12 @@
       String SPOOLING_BUFFER_MEMORY = "drill.exec.buffer.spooling.size";
       String BATCH_PURGE_THRESHOLD = "drill.exec.sort.purge.threshold";
     
    +  // Spill Options common to all spilling operators
    --- End diff --
    
    OK, boot-time. Wish Drill had a clear way to distinguish boot-time from session options.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---