Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: kkhatua <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-826-drill@git.apache.org>
In-Reply-To: <git-pr-826-drill@git.apache.org>
Subject: [GitHub] drill pull request #826: DRILL-5379: Set Hdfs Block Size based on Parquet Bl...
Content-Type: text/plain
Message-Id: <20170517210025.BD8DCDFF17@git1-us-west.apache.org>
Date: Wed, 17 May 2017 21:00:25 +0000 (UTC)
archived-at: Wed, 17 May 2017 21:00:28 -0000

Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/826#discussion_r117108770
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -160,6 +160,9 @@
       OptionValidator OUTPUT_FORMAT_VALIDATOR = new StringValidator(OUTPUT_FORMAT_OPTION, "parquet");
       String PARQUET_BLOCK_SIZE = "store.parquet.block-size";
       OptionValidator PARQUET_BLOCK_SIZE_VALIDATOR = new LongValidator(PARQUET_BLOCK_SIZE, 512*1024*1024);
    +  String PARQUET_WRITER_USE_CONFIGURED_BLOCK_SIZE = "store.parquet.writer.use_configured_block-size";
    --- End diff --
    
    Making my contribution to the review thread:
    `match_filesystem_block-size`
    The value would be the logical inverse of the original flag. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---