Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: jinfengni <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-819-drill@git.apache.org>
In-Reply-To: <git-pr-819-drill@git.apache.org>
Subject: [GitHub] drill issue #819: DRILL-5419: Calculate return string length for literals & ...
Content-Type: text/plain
Message-Id: <20170511175231.47278DFE61@git1-us-west.apache.org>
Date: Thu, 11 May 2017 17:52:31 +0000 (UTC)
archived-at: Thu, 11 May 2017 17:52:33 -0000

Github user jinfengni commented on the issue:

    https://github.com/apache/drill/pull/819
  
    +1
    
    The revised commit looks good to me. Thanks for taking effort to separate the return type inference logic from function scope logic. You may consider adding brief description of that change, plus the  refactoring of part of function code-gen logic (ValueReference etc).
    
      
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---