Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: ppadma <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-827-drill@git.apache.org>
In-Reply-To: <git-pr-827-drill@git.apache.org>
Subject: [GitHub] drill pull request #827: DRILL-5481: Persist profiles in-memory only with a ...
Content-Type: text/plain
Message-Id: <20170510041851.B41DCDFBAB@git1-us-west.apache.org>
Date: Wed, 10 May 2017 04:18:51 +0000 (UTC)
archived-at: Wed, 10 May 2017 04:18:54 -0000

Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/827#discussion_r115635985
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/InMemoryPersistentStore.java ---
    @@ -93,6 +106,14 @@ public void put(final String key, final V value, final DataChangeVersion dataCha
             throw new VersionMismatchException("Version mismatch detected", dataChangeVersion.getVersion());
           }
           store.put(key, value);
    +      currentSize.incrementAndGet();
    +
    +      if (currentSize.get() > maxCapacity) {
    --- End diff --
    
    I guess you can combine and make it if (currentSize.incrementAndGet() > maxCapacity)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---