Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: bitblender <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-809-drill@git.apache.org>
In-Reply-To: <git-pr-809-drill@git.apache.org>
Subject: [GitHub] drill pull request #809: Drill-4335: C++ client changes for supporting encry...
Content-Type: text/plain
Message-Id: <20170508233511.2C3F3DFAB4@git1-us-west.apache.org>
Date: Mon,  8 May 2017 23:35:11 +0000 (UTC)
archived-at: Mon, 08 May 2017 23:35:13 -0000

Github user bitblender commented on a diff in the pull request:

    https://github.com/apache/drill/pull/809#discussion_r114818140
  
    --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
    @@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults(){
         }
     }
     
    -status_t DrillClientImpl::readMsg(ByteBuf_t _buf,
    -        AllocatedBufferPtr* allocatedBuffer,
    +/*
    + *  Decode the length of the message from bufWithLen and then read entire message from the socket.
    + *  Parameters:
    + *      bufWithLen          - in param  - buffer containing the bytes which has length of the RPC message/encrypted chunk
    + *      bufferWithLenBytes  - out param - buffer pointer which points to memory allocated in this function and has the
    + *                                        entire one RPC message / encrypted chunk along with the length of the message
    + *      lengthBytesLength   - out param - bytes of bufWithLen which contains the length of the entire RPC message or
    + *                                        encrypted chunk
    + *      lengthDecodeHandler - in param  - function pointer with length decoder to use. For encrypted chunk we use
    + *                                        lengthDecode and for plain RPC message we use rpcLengthDecode.
    + *  Return:
    + *      status_t    - QRY_SUCCESS    - In case of success.
    + *                  - QRY_COMM_ERROR/QRY_INTERNAL_ERROR/QRY_CLIENT_OUTOFMEM - In cases of error.
    + */
    +status_t DrillClientImpl::readLenBytesFromSocket(ByteBuf_t bufWithLen, AllocatedBufferPtr* bufferWithLenBytes,
    +		uint32_t& lengthBytesLength, lengthDecoder lengthDecodeHandler) {
    +
    +    uint32_t rmsgLen = 0;
    +    size_t bytes_read = 0;
    +    size_t leftover = 0;
    +    boost::system::error_code error;
    +    *bufferWithLenBytes = NULL;
    +    size_t bufferWithLenBytesSize = 0;
    +
    +    bytes_read = (this->*lengthDecodeHandler)(bufWithLen, rmsgLen);
    --- End diff --
    
    What does it mean to access a local using the 'this' ptr?
    Can't this be written as bytes_read = (lengthDecodeHandler)(bufWithLen, rmsgLen); ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---