Return-Path: <dev-return-28748-archive-asf-public=cust-asf.ponee.io@drill.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id CF0E8200CA3
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue,  2 May 2017 23:03:08 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id CD8E5160BBE; Tue,  2 May 2017 21:03:08 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 22171160BAC
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  2 May 2017 23:03:07 +0200 (CEST)
Received: (qmail 36065 invoked by uid 500); 2 May 2017 21:03:06 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 35799 invoked by uid 99); 2 May 2017 21:03:06 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 May 2017 21:03:06 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 462DBDF9A3; Tue,  2 May 2017 21:03:06 +0000 (UTC)
From: gparai <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-811-drill@git.apache.org>
In-Reply-To: <git-pr-811-drill@git.apache.org>
Subject: [GitHub] drill pull request #811: DRILL-5423: Refactor ScanBatch to allow unit testin...
Content-Type: text/plain
Message-Id: <20170502210306.462DBDF9A3@git1-us-west.apache.org>
Date: Tue,  2 May 2017 21:03:06 +0000 (UTC)
archived-at: Tue, 02 May 2017 21:03:09 -0000

Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/811#discussion_r114399420
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorUtilities.java ---
    @@ -0,0 +1,41 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.ops;
    +
    +import java.util.Iterator;
    +
    +import org.apache.drill.exec.physical.base.PhysicalOperator;
    +
    +public class OperatorUtilities {
    +
    +  private OperatorUtilities() { }
    +
    +  public static int getChildCount(PhysicalOperator popConfig) {
    +    Iterator<PhysicalOperator> iter = popConfig.iterator();
    +    int i = 0;
    --- End diff --
    
    Refactor i -> count


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---