Return-Path: <dev-return-28721-archive-asf-public=cust-asf.ponee.io@drill.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 16BD6200C8C
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue,  2 May 2017 01:08:02 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 155F9160BC4; Mon,  1 May 2017 23:08:02 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 5F2A7160BC3
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  2 May 2017 01:08:01 +0200 (CEST)
Received: (qmail 32337 invoked by uid 500); 1 May 2017 23:08:00 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 31990 invoked by uid 99); 1 May 2017 23:07:59 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 May 2017 23:07:59 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 86DB7DFB8A; Mon,  1 May 2017 23:07:59 +0000 (UTC)
From: sudheeshkatkam <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-773-drill@git.apache.org>
In-Reply-To: <git-pr-773-drill@git.apache.org>
Subject: [GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...
Content-Type: text/plain
Message-Id: <20170501230759.86DB7DFB8A@git1-us-west.apache.org>
Date: Mon,  1 May 2017 23:07:59 +0000 (UTC)
archived-at: Mon, 01 May 2017 23:08:02 -0000

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r114216967
  
    --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcMetrics.java ---
    @@ -0,0 +1,33 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * <p>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.drill.exec.rpc;
    +
    +import org.apache.drill.exec.memory.BufferAllocator;
    +
    +/**
    + * Holder interface for all the metrics used in RPC layer
    + */
    +public interface RpcMetrics {
    --- End diff --
    
    -0 for this plumbing.
    
    The end result is that only static state (counters) is being modified using instances, which is not recommended ([ref](http://stackoverflow.com/questions/6832767/how-to-modify-private-static-variable-through-setter-method)). So the hierarchy is not required.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---