Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: sohami <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-773-drill@git.apache.org>
In-Reply-To: <git-pr-773-drill@git.apache.org>
Subject: [GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...
Content-Type: text/plain
Message-Id: <20170501194748.78661DF999@git1-us-west.apache.org>
Date: Mon,  1 May 2017 19:47:48 +0000 (UTC)
archived-at: Mon, 01 May 2017 19:47:51 -0000

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r113376608
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java ---
    @@ -243,4 +249,46 @@ public SaslMessage process(SaslChallengeContext context) throws Exception {
           }
         }
       }
    +
    +  private static void handleSuccess(SaslChallengeContext context) throws SaslException {
    +    final ClientConnection connection = context.connection;
    +    final SaslClient saslClient = connection.getSaslClient();
    +
    +    try {
    +      // Check if connection was marked for being secure then verify for negotiated QOP value for
    +      // correctness.
    +      final String negotiatedQOP = saslClient.getNegotiatedProperty(Sasl.QOP).toString();
    --- End diff --
    
    Null QOP is not auth. Instead when we pass QOP as null the mechanism will use the default QOP value for negotiation which is auth. So getNegotiatedProperty will always return a valid object.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---