Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: sohami <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-773-drill@git.apache.org>
In-Reply-To: <git-pr-773-drill@git.apache.org>
Subject: [GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...
Content-Type: text/plain
Message-Id: <20170501194748.7757EE0896@git1-us-west.apache.org>
Date: Mon,  1 May 2017 19:47:48 +0000 (UTC)
archived-at: Mon, 01 May 2017 19:47:51 -0000

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r113834772
  
    --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/EncryptionContext.java ---
    @@ -0,0 +1,37 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.drill.exec.rpc;
    +
    +public interface EncryptionContext {
    --- End diff --
    
    As discussed keeping as is. The main purpose of changing to a separate interface for EncryptionContext was to keep RemoteConnection interface as is which was the concern in previous comment. Doing getEncryptionOptions to return the instance of EncryptionContextImpl gives control to the caller to set and get upon the instance. Since instance is private to a connection it should only be allowed to change the state and caller will only have exposure to the functions as needed.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---