drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #822: DRILL-5457: Spill implementation for Hash Aggregate
Date Wed, 31 May 2017 02:02:57 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r119256700
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
    @@ -204,24 +293,157 @@ private int getNumPendingOutput() {
     
         @RuntimeOverridden
         public void setupInterior(@Named("incoming") RecordBatch incoming, @Named("outgoing")
RecordBatch outgoing,
    -        @Named("aggrValuesContainer") VectorContainer aggrValuesContainer) {
    +        @Named("aggrValuesContainer") VectorContainer aggrValuesContainer) throws SchemaChangeException
{
         }
     
         @RuntimeOverridden
    -    public void updateAggrValuesInternal(@Named("incomingRowIdx") int incomingRowIdx,
@Named("htRowIdx") int htRowIdx) {
    +    public void updateAggrValuesInternal(@Named("incomingRowIdx") int incomingRowIdx,
@Named("htRowIdx") int htRowIdx) throws SchemaChangeException{
         }
     
         @RuntimeOverridden
    -    public void outputRecordValues(@Named("htRowIdx") int htRowIdx, @Named("outRowIdx")
int outRowIdx) {
    +    public void outputRecordValues(@Named("htRowIdx") int htRowIdx, @Named("outRowIdx")
int outRowIdx) throws SchemaChangeException{
         }
       }
     
    +  /**
    +   * An internal class to replace "incoming" - instead scanning a spilled partition file
    +   */
    +  public class SpilledRecordbatch implements CloseableRecordBatch {
    --- End diff --
    
    Moved out the inner class into an independent class. (The "static inner class" approach
failed due to a possible bug with Drill bytecode fixup -- the first parameter in the constructor
was eliminated in the generated code).
      Extending the record batch interface was intentional - this leads to a very neat handling
of the batch in the Hash Agg -- no code change, just like handling the batches incoming from
upstream.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message