drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #822: DRILL-5457: Spill implementation for Hash Aggregate
Date Wed, 31 May 2017 00:11:02 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r119245285
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
    @@ -166,20 +252,23 @@ public BatchHolder() {
         }
     
         private boolean updateAggrValues(int incomingRowIdx, int idxWithinBatch) {
    -      updateAggrValuesInternal(incomingRowIdx, idxWithinBatch);
    +      try { updateAggrValuesInternal(incomingRowIdx, idxWithinBatch); }
    +      catch (SchemaChangeException sc) { throw new DrillRuntimeException(sc); }
    --- End diff --
    
    Yes, but only when %100 sure; else if there's a chance for a SchemaChange -- Better use
UnsupportedOperationException ...  
      Code change done !!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message