drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #846: DRILL-5544: Out of heap running CTAS against text d...
Date Tue, 30 May 2017 21:52:06 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/846#discussion_r119180018
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java
---
    @@ -268,8 +278,7 @@ private void flush() throws IOException {
         }
     
         store.close();
    -    // TODO(jaltekruse) - review this close method should no longer be necessary
    -//    ColumnChunkPageWriteStoreExposer.close(pageStore);
    +    pageStore.close();
    --- End diff --
    
    This is existing code; but seems that the above code should be in a try block, with close
in the finally, to ensure that the close occurs even if a write or other error occurs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message