drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #818: DRILL-5140: Fix CompileException in run-time genera...
Date Fri, 26 May 2017 17:47:18 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/818#discussion_r118755301
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java
---
    @@ -77,10 +81,43 @@
       private final CodeGenerator<T> codeGenerator;
     
       public final JDefinedClass clazz;
    -  private final LinkedList<SizedJBlock>[] blocks;
    +
       private final JCodeModel model;
       private final OptionSet optionManager;
     
    +  private ClassGenerator<T> innerClassGenerator;
    +  private LinkedList<SizedJBlock>[] blocks;
    +  private LinkedList<SizedJBlock>[] oldBlocks;
    +
    +  /**
    +   * Assumed that field has 3 indexes within the constant pull: index of the CONSTANT_Fieldref_info
+
    --- End diff --
    
    Although the proposed formula might still hit problem in certain cases,  it seems to work
fine for normal cases. Also, for normal queries over hundreds of columns, the run-time generated
code remains same as before. Given that, it makes sense to me to merge this code change. 
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message