drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #829: DRILL-5485: Remove WebServer dependency on DrillCli...
Date Thu, 25 May 2017 20:55:04 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/829#discussion_r118582764
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/UserClientConnection.java
---
    @@ -0,0 +1,69 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.rpc;
    +
    +import io.netty.channel.ChannelFuture;
    +import org.apache.drill.exec.physical.impl.materialize.QueryWritableBatch;
    +import org.apache.drill.exec.proto.GeneralRPCProtos;
    +import org.apache.drill.exec.proto.UserBitShared;
    +import org.apache.drill.exec.rpc.user.UserSession;
    +
    +import java.net.SocketAddress;
    +
    +/**
    + * Interface for getting user session properties and interacting with user connection.
Separating this interface from
    + * {@link AbstractRemoteConnection} implementation for user connection:
    + * <p><ul>
    + * <li> Connection is passed to Foreman and Screen operators. Instead passing this
interface exposes few details.
    + * <li> Makes it easy to have wrappers around user connection which can be helpful
to tap the messages and data
    + * going to the actual client.
    + * </ul>
    + */
    +public interface UserClientConnection {
    +  /**
    +   * @return User session object.
    +   */
    +  UserSession getSession();
    +
    +  /**
    +   * Send query result outcome to client. Outcome is returned through <code>listener</code>
    +   *
    +   * @param listener
    +   * @param result
    +   */
    +  void sendResult(RpcOutcomeListener<GeneralRPCProtos.Ack> listener, UserBitShared.QueryResult
result);
    --- End diff --
    
    Not fixed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message