drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdunning <...@git.apache.org>
Subject [GitHub] drill pull request #831: DRILL-5432: Added pcap-format support
Date Thu, 25 May 2017 01:19:15 GMT
Github user tdunning commented on a diff in the pull request:

    https://github.com/apache/drill/pull/831#discussion_r118399621
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Packet.java
---
    @@ -0,0 +1,371 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.pcap.decoder;
    +
    +import com.google.common.base.Preconditions;
    +
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.net.InetAddress;
    +import java.net.UnknownHostException;
    +
    +import static org.apache.drill.exec.store.pcap.Utils.convertInt;
    +import static org.apache.drill.exec.store.pcap.Utils.convertShort;
    +import static org.apache.drill.exec.store.pcap.Utils.getByte;
    +import static org.apache.drill.exec.store.pcap.Utils.getIntFileOrder;
    +import static org.apache.drill.exec.store.pcap.Utils.getShort;
    +
    +public class Packet {
    +  // pcap header
    +  //        typedef struct pcaprec_hdr_s {
    +  //            guint32 ts_sec;         // timestamp seconds
    +  //            guint32 ts_usec;        // timestamp microseconds */
    +  //            guint32 incl_len;       // number of octets of packet saved in file */
    +  //            guint32 orig_len;       // actual length of packet */
    +  //        } pcaprec_hdr_t;
    +  private long timestamp;
    +  private int originalLength;
    +
    +  private byte[] raw;
    +
    +  private int etherOffset;
    +  private int ipOffset;
    +
    +  private int packetLength;
    +  private int etherProtocol;
    +  private int protocol;
    +
    +  private boolean isRoutingV6;
    +
    +  @SuppressWarnings("WeakerAccess")
    +  public boolean readPcap(final InputStream in, final boolean byteOrder, final int maxLength)
throws IOException {
    +    byte[] pcapHeader = new byte[PacketConstants.PCAP_HEADER_SIZE];
    +    int n = in.read(pcapHeader);
    +    if (n < pcapHeader.length) {
    +      return false;
    +    }
    +    decodePcapHeader(pcapHeader, byteOrder, maxLength, 0);
    +
    +    raw = new byte[originalLength];
    +    n = in.read(raw);
    +    if (n < 0) {
    +      return false;
    +    }
    +    etherOffset = 0;
    +
    +    decodeEtherPacket();
    +    return true;
    +  }
    +
    +  @SuppressWarnings("WeakerAccess")
    +  public int decodePcap(final byte[] buffer, final int offset, final boolean byteOrder,
final int maxLength) {
    +    raw = buffer;
    +    etherOffset = offset + PacketConstants.PCAP_HEADER_SIZE;
    +    decodePcapHeader(raw, byteOrder, maxLength, offset);
    +    decodeEtherPacket();
    +    return offset + PacketConstants.PCAP_HEADER_SIZE + originalLength;
    +  }
    +
    +  public String getPacketType() {
    +    if (isTcpPacket()) {
    +      return "TCP";
    +    } else if (isUdpPacket()) {
    +      return "UDP";
    +    } else if (isArpPacket()) {
    +      return "ARP";
    +    } else if (isIcmpPacket()) {
    +      return "ICMP";
    +    } else {
    +      return "unknown";
    +    }
    +  }
    +
    +  @SuppressWarnings("WeakerAccess")
    +  public boolean isIpV4Packet() {
    +    return etherProtocol == PacketConstants.IPv4_TYPE;
    +  }
    +
    +  @SuppressWarnings("WeakerAccess")
    +  public boolean isIpV6Packet() {
    +    return etherProtocol == PacketConstants.IPv6_TYPE;
    +  }
    +
    +  @SuppressWarnings("WeakerAccess")
    +  public boolean isPPPoV6Packet() {
    +    return etherProtocol == PacketConstants.PPPoV6_TYPE;
    +  }
    +
    +  @SuppressWarnings("WeakerAccess")
    +  public boolean isTcpPacket() {
    +    return protocol == PacketConstants.TCP_PROTOCOL;
    +  }
    +
    +  @SuppressWarnings("WeakerAccess")
    +  public boolean isUdpPacket() {
    +    return protocol == PacketConstants.UDP_PROTOCOL;
    +  }
    +
    +  @SuppressWarnings("WeakerAccess")
    +  public boolean isArpPacket() {
    +    return protocol == PacketConstants.ARP_PROTOCOL;
    +  }
    +
    +  @SuppressWarnings("WeakerAccess")
    +  public boolean isIcmpPacket() {
    +    return protocol == PacketConstants.ICMP_PROTOCOL;
    +  }
    +
    +  public long getSessionHash() {
    --- End diff --
    
    This is very useful. It is the way that TCP sessions are reassembled (which is a big deal).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message