drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #829: DRILL-5485: Remove WebServer dependency on DrillCli...
Date Wed, 24 May 2017 07:03:35 GMT
Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/829#discussion_r118160625
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractUserClientConnectionWrapper.java
---
    @@ -0,0 +1,101 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.rpc;
    +
    +import com.google.common.base.Preconditions;
    +import org.apache.drill.common.exceptions.UserException;
    +import org.apache.drill.common.exceptions.UserRemoteException;
    +import org.apache.drill.exec.proto.GeneralRPCProtos;
    +import org.apache.drill.exec.proto.UserBitShared.DrillPBError;
    +import org.apache.drill.exec.proto.UserBitShared.QueryId;
    +import org.apache.drill.exec.proto.UserBitShared.QueryResult;
    +import org.apache.drill.exec.proto.helper.QueryIdHelper;
    +
    +import java.util.concurrent.CountDownLatch;
    +import java.util.concurrent.TimeUnit;
    +
    +public abstract class AbstractUserClientConnectionWrapper implements UserClientConnection
{
    +  private static final org.slf4j.Logger logger =
    +      org.slf4j.LoggerFactory.getLogger(AbstractUserClientConnectionWrapper.class);
    +
    +  protected final CountDownLatch latch = new CountDownLatch(1);
    +
    +  protected volatile DrillPBError error;
    +
    +  protected volatile UserException exception;
    +
    +  /**
    +   * Wait until the query has completed or timeout is passed.
    +   *
    +   * @throws InterruptedException
    +   */
    +  public boolean await(final long timeoutMillis) throws InterruptedException {
    +    return latch.await(timeoutMillis, TimeUnit.MILLISECONDS);
    +  }
    +
    +  /**
    +   * Wait indefinitely until the query is completed. Used only in case of WebUser
    +   *
    +   * @throws Exception
    +   */
    +  public void await() throws Exception {
    +    latch.await();
    +    if (exception != null) {
    +      throw exception;
    +    }
    +  }
    +
    +  @Override
    +  public void sendResult(RpcOutcomeListener<GeneralRPCProtos.Ack> listener, QueryResult
result) {
    +
    +    Preconditions.checkState(result.hasQueryState());
    +
    +    // Release the wait latch if the query is terminated.
    +    final QueryResult.QueryState state = result.getQueryState();
    +    final QueryId queryId = result.getQueryId();
    +
    +    if (logger.isDebugEnabled()) {
    +      logger.debug("Result arrived for QueryId: {} with QueryState: {}", QueryIdHelper.getQueryId(queryId),
state);
    +    }
    +
    +    switch (state) {
    +      case FAILED:
    +        error = result.getError(0);
    +        exception = new UserRemoteException(error);
    +        latch.countDown();
    +        break;
    +      case CANCELED:
    +      case COMPLETED:
    +        Preconditions.checkState(result.getErrorCount() == 0);
    +        latch.countDown();
    +        break;
    +      default:
    +        logger.error("Query with QueryId: {} is in unexpected state: {}", queryId, state);
    --- End diff --
    
    In [DrillClient](https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java#L134)
we just log and ignore any invalid QueryState. Looks like client always expect a valid state
to be reported for the query ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message