drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #822: DRILL-5457: Spill implementation for Hash Aggregate
Date Wed, 24 May 2017 03:02:35 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r118153400
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/ExternalSort.java
---
    @@ -49,12 +49,19 @@ public int getOperatorType() {
         return CoreOperatorType.EXTERNAL_SORT_VALUE;
       }
     
    -  // Set here, rather than the base class, because this is the only
    -  // operator, at present, that makes use of the maximum allocation.
    -  // Remove this, in favor of the base class version, when Drill
    -  // sets the memory allocation for all operators.
    -
    +  /**
    --- End diff --
    
    But still need a local comment to be clear about this code .... so does not matter much.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message