drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #822: DRILL-5457: Spill implementation for Hash Aggregate
Date Tue, 23 May 2017 20:52:27 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r118103592
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -86,6 +92,19 @@
     
       BooleanValidator EXTERNAL_SORT_DISABLE_MANAGED_OPTION = new BooleanValidator("exec.sort.disable_managed",
false);
     
    +  // Hash Aggregate Options
    +
    +  String HASHAGG_NUM_PARTITIONS_KEY = "drill.exec.hashagg.num_partitions";
    --- End diff --
    
    Changed all three to have both the config option ("drill.exec.hashagg....") and its matching
_KEY (same, sans the prefix "drill.") which is only used to create the validator.
    Hence all three can be set either in the config file, or for the session: 
    Number of partitions, max memory, and minimum batches per partitions.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message