drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #829: DRILL-5485: Remove WebServer dependency on DrillCli...
Date Tue, 23 May 2017 20:40:42 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/829#discussion_r117881581
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillUserPrincipal.java
---
    @@ -18,43 +18,37 @@
     package org.apache.drill.exec.server.rest.auth;
     
     import com.google.common.collect.ImmutableList;
    -import org.apache.drill.common.AutoCloseables;
    -import org.apache.drill.exec.client.DrillClient;
    -import org.apache.drill.exec.server.DrillbitContext;
     import org.eclipse.jetty.security.MappedLoginService.RolePrincipal;
     
    -import java.io.IOException;
     import java.security.Principal;
     import java.util.List;
     
    +
     /**
      * Captures Drill user credentials and resources in a session.
      */
     public class DrillUserPrincipal implements Principal, AutoCloseable {
    --- End diff --
    
    `close` is a no-op. Remove `implements AutoCloseable` and corresponding calls.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message