drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #829: DRILL-5485: Remove WebServer dependency on DrillCli...
Date Tue, 23 May 2017 20:40:42 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/829#discussion_r117881390
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/AbstractDrillLoginService.java
---
    @@ -37,30 +33,10 @@
       protected final DrillbitContext drillbitContext;
       protected IdentityService identityService = new DefaultIdentityService();
     
    -  public AbstractDrillLoginService(final DrillbitContext drillbitContext) {
    +  protected AbstractDrillLoginService(final DrillbitContext drillbitContext) {
    --- End diff --
    
    This abstract class isn't required. Move logic to `DrillRestLoginService`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message